kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #25715
Re: [PATCH] Memoize SHAPE_LINE_CHAIN bounding box computation
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Thu, 11 Aug 2016 15:45:26 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<713bc6f2-341c-9edc-bd6b-376fc78cbb41@gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
Just to let you know: I had asked Tom and he had had nothing against the
patch, so Chris has committed it.
Regards,
Orson
On 08/10/2016 04:19 PM, Wayne Stambaugh wrote:
> Orson & Tom,
>
> Please look over this patch when you get a chance to see if it makes
> sense to commit it.
>
> Thanks,
>
> Wayne
>
> On 8/6/2016 9:36 PM, Chris Pavlina wrote:
>> The board I'm working on is quite complex and makes KiCad _very_ slow,
>> so I'm working on a bit of profiling and optimizing. The attached patch
>> memoizes SHAPE_LINE_CHAIN bounding box computation, which is a hot spot
>> during netlist sync (presumably when trace/net connections are
>> calculated). For my specific case, it results in a 38% speedup, from 21
>> seconds down to 13 seconds.
>>
>> Next hotspot to tackle is NETLIST_OBJECT_LIST::BuildNetListInfo :)
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
References