kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 8/12/2016 10:44 AM, Maciej Sumiński wrote:
> On 08/12/2016 04:38 PM, Wayne Stambaugh wrote:
> [snip]
>>> Hi Orson,
>>>
>>> I saw your commit.  Thanks for addressing this issue in a timely mannor.
>>>  I have on minor comment.  FindFoo.cmake files should always have an
>>> option to override the default find location which should take
>>> precedence over the default locations.  Typically this is done with an
>>> environment variable and a definition such as FOO_ROOT.  This allows
>>> developers to use development libraries without having to overwrite
>>> their system default libraries.  I know many of the find modules that
>>> ship with cmake do not do this.  We should not be repeating this bad habit.
> 
> Currently there are variables NGSPICE_INCLUDE_PATH and
> NGSPICE_LIBRARY_PATH serving this purpose. I will have a look how is it
> done in other modules and try to make it coherent.
> 
>> Whoops!  I forgot to mention, version testing is always a good idea.  At
>> some point it will be an issue and you will have to add support for it.
> 
> I thought about this, but the information is not stored anywhere in the
> header file, and the library always gets 0.0.0 number (e.g.
> libngspice.so.0.0.0), so currently I am out of ideas.
> 
> Regards,
> Orson

Yuck!  This is not my idea of a quality library.  The next time you talk
to them, ask them to please include a version string somewhere in their
header files and version their libraries.  Better yet, tell them to
generate this automatically with their build configuration tools.  I
can't believe one of the distros hasn't beat them over the head about
this yet.

> 
>>> Thanks,
>>>
>>> Wayne
>>>
>>>>
>>>>> Thanks again everyone for your hard work.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Wayne
>>>>
>>>>
>>>
>>
> 
>