← Back to team overview

kicad-developers team mailing list archive

Re: -Wsuggest-override with scripting enabled

 

Le 06/10/2016 à 01:07, Wayne Stambaugh a écrit :
> On 10/5/2016 5:42 PM, José Ignacio wrote:
>> On Wed, Oct 5, 2016 at 3:55 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> pcbnewPYTHON_wrap.cxx
>>
>> That file is a source of pain, it appears to be generated by swig as a
>> side effect and it does go stale sometimes (whenever there is a
>> breaking change in the python api) as cmake is not keeping track of it
>> (the only solution is to delete that file and rebuild, or do a clean
>> build). I tried adding it as the list of generated files in the
>> cmakelists but had no effect.
>>
> 
> I did an clean config and build but still have this issue.  If you
> delete pcbnewPYTHON_wrap.cxx, it will automatically get regenerated so
> you solution doesn't work.  I'm not sure what to do about this.
> 

It works for me, but I had to  modify the patch
the change in pcbnew/CMakeLists.txt is
    if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
        set_source_files_properties(pcbnew_wrap.cxx pcbnewPYTHON_wrap.cxx
            PROPERTIES COMPILE_FLAGS -Wno-suggest-override
        )

instead of
    if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
        set_source_files_properties(pcbnew_wrap.cxx
            PROPERTIES COMPILE_FLAGS -Wno-suggest-override
        )

(In the initial patch  pcbnewPYTHON_wrap.cxx is missing in set_source_files_properties file list)

-- 
Jean-Pierre CHARRAS


Follow ups

References