kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #26546
Re: PATCH: change test for invalid numeric strings in VRML files
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Sun, 9 Oct 2016 09:14:39 -0400
-
In-reply-to:
<CAHBNN+M+ev-A0rUotDFqUqOu0Gc7Kq=adFyyBzd6r4mkOJ56ZQ@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
Patch committed. Thanks!
On 9/26/2016 6:53 AM, Cirilo Bernardo wrote:
> The attached patch changes a test for invalid numeric strings
> in VRML1,2 and X3D files. The long-winded and convoluted
> tests similar in form to:
>
> istr >> aSFFloat;
> tmp.clear();
> istr >> tmp;
>
> if( !tmp.empty() )
>
> Are replaced with a more obvious and shorter test:
>
> istr >> aSFFloat;
> if( istr.fail() || !istr.eof() )
>
> - Cirilo
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References