kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

The patch seems reasonable to me. Currently with touchpad panning
enabled there is no way to zoom with the scroll motion. With the patch
applied zoom both are enabled. I do not have a two-wheel mouse or a
touchpad to test if everything works well for the second axis, but the
patch seems correct.

I could not apply the second patch, it gives me "unexpected end of file
in patch" error. Would you verify the file?

There is one thing that could be improved. Currently wheel scroll and
shift+scroll behave identically. Perhaps pressing shift could select the
axis for panning. Just an idea.

Regards,
Orson

On 11/12/2016 09:35 PM, Константин Барановский wrote:
> New version of the patch that works in legacy/opengl/cairo/3d_viewer.
> 
> Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
> it.
> 
> 2016-11-12 9:33 GMT+02:00 Константин Барановский <
> baranovskiykonstantin@xxxxxxxxx>:
> 
>> Hmm. This patch really works only in legacy mode and doesn't work in GAL
>> mode, but I don't understand why. It looks like both modes legacy and GAL
>> used the same event  handler for mouse wheel event, but still does not
>> work. Can anyone to point me to right direction for searching, please?
>>
>> 2016-11-11 21:46 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>
>>> Thanks Bernhard.  The behavior should be the same for the gal canvas and
>>> the 3d-viewer.
>>>
>>> On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
>>>> I’ll try to test ASAP, but I can’t promise when.
>>>>
>>>> At least on first glance it seems to be somewhat incomplete.
>>>> It only seems to change legacy canvas, but not GAL canvas or 3d-viewer,
>>> which
>>>> should probably behave the same then?
>>>>
>>>>
>>>> Regards,
>>>> Bernhard
>>>>
>>>>> On 11 Nov 2016, at 16:04, Wayne Stambaugh <stambaughw@xxxxxxxxx>
>>> wrote:
>>>>>
>>>>> This doesn't break anything on osx does it?  That is what I need to
>>> know
>>>>> before I commit the patch.  Would one of the osx devs please confirm
>>>>> this form me when you get a chance?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Wayne
>>>>>
>>>>> On 11/11/2016 10:01 AM, Константин Барановский wrote:
>>>>>> I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
>>>>>> scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
>>>>>>
>>>>>> 2016-11-11 16:31 GMT+02:00 Brano Panak <bpanak@xxxxxxxxx
>>>>>> <mailto:bpanak@xxxxxxxxx>>:
>>>>>>
>>>>>>    in osx even without this patch this functionality works (cmd+ mouse
>>>>>>    wheel is zooming).
>>>>>>
>>>>>>
>>>>>>    On 10/11/16 11:41, Константин Барановский wrote:
>>>>>>>    That patch allows to use mouse wheel + ctrl for zooming, when
>>>>>>>    option "Use touchpad to pan" is enabled.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>    _______________________________________________
>>>>>>>    Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>    <https://launchpad.net/~kicad-developers>
>>>>>>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>    Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>    <https://launchpad.net/~kicad-developers>
>>>>>>>    More help   : https://help.launchpad.net/ListHelp
>>>>>>>    <https://help.launchpad.net/ListHelp>
>>>>>>
>>>>>>
>>>>>>    _______________________________________________
>>>>>>    Mailing list: https://launchpad.net/~kicad-developers
>>>>>>    <https://launchpad.net/~kicad-developers>
>>>>>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>    Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>    <https://launchpad.net/~kicad-developers>
>>>>>>    More help   : https://help.launchpad.net/ListHelp
>>>>>>    <https://help.launchpad.net/ListHelp>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature