kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Correct.  Do we really need override the entire version string?  I've
been working under the assumption that we should be setting the base
version and users can use the optional variables to append to the base
version.  If we allow users to set the base version to anything, that
would open us up to version conflicts and/or errors (which has happened
in the past). I'm open to this idea but I want to make sure it's
necessary before I make any changes.  For stable releases, KICAD_VERSION
will be set to the version number so that should always be part of the
version string for stable releases.  This will work with source archives
and a git clone of the release tag.  In all other cases, the git
determines the base version string.

On 11/25/2016 9:42 AM, Nick Østergaard wrote:
> So this does not allow to override the string entirely with a cmake
> variable? Like in the PPA use case.
> 
> 2016-11-25 15:24 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>> In preparation for the next stable 4 release, I simplified the version
>> string code which means there are some differences for specifying
>> version string information at config time.  The new code uses the
>> following CMake variables to build the version string:
>>
>> ${KICAD_VERSION}[-${KICAD_BRANCH_NAME}][-${KICAD_VERSION_EXTRA}]
>>
>> where variables inside the brackets [] are optional and can be set at
>> configuration.  The KICAD_VERSION variable is either set in the
>> KiCadVersion.cmake file or by git.  It is not user configurable and is
>> always defined.  When git is used to determine the version string,
>> KICAD_BRANCH_NAME is set to the git branch.  In all other cases,
>> KICAD_BRANCH_NAME is empty.  KICAD_VERSION_EXTRA is always set at
>> config.  I updated the building from source doc if you need additional
>> information.
>>
>> I'm hoping this is the last time I have to deal with this issue.  It
>> should cover most if not all use cases.  Please do not change this code
>> without checking with me first.  If you find any issues, let me know so
>> I can get them resolved.  Sorry for the inconvenience.
>>
>> Cheers,
>>
>> Wayne
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp