← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] mousewheelpan + ctrl = zooming

 

Hi Orson,

this occurs when touchpad panning enabled. When TP panning disabled wheel works ok (withou need to push ctrl).

When TP panning enabled it zoom in work ok. When zooming out it look to me that sw zooms out and immediately zooms in again.

I am using wireless apple mouse which has both (vertical and horizontal) "wheels".

When trying to zoom in/out with ctrl+ horizontal "wheel" all works ok.

If i remember correctly this was working ok, befor latest "wheel" patch.

regards

Brano


On 20/01/17 08:52, Maciej Sumiński wrote:
Hi Brano,

Are the problems occurring when touchpad panning is enabled? Is
everything fine once you disable it?

Would you give more details about zoom out being problematic? Does it
zoom out too quickly, is it choppy?

Regards,
Orson

On 01/19/2017 10:52 PM, Brano Panak wrote:
Today i checked behavior on osx with version: (2017-01-18 revision
2eb840b)-master
and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
apple mouse  is very erratic.

Zoom in works ok, zoom out is very problematic.

Eeschema looks ok, pcbnew with zooming and scrolling on touchpad with 2
fingers looks good.

regards

Brano


On 17/01/17 18:17, Константин Барановский wrote:
In attachment placed new patch, that contains both previous patches
and in mousewheelpan mode, with pressed Shift key, does horizontal
scrolling.

So, in common, we will get:

* mousewheelpan disabled:
- mousewheel = zooming;
- mousewheel + ctrl = horizontal scrolling;
- mousewheel + shift = vertical scrolling;

* mousewheelpan enabled:
- touchpad two finger scrolling = pan;
- mousewheel = vertical scrolling;
-> mousewheel (touchpad two finger scrolling) + ctrl = zooming;
-> mousewheel (touchpad two finger scrolling)  + shift = horizontal
scrolling.

This patch adds two last options and decreases the pan step in
3d-viewer to be more comfortable.
It works in eeschema, pcbnew (legacy, openGL, cairo), 3d-viewer,
gerbview.

2017-01-17 11:27 GMT+02:00 Maciej Sumiński <maciej.suminski@xxxxxxx
<mailto:maciej.suminski@xxxxxxx>>:

     Hi Konstantin,

     Your patches were not ignored, the problem was neither me nor Wayne
     could fully apply the patches in their original version. Thank you
for
     correcting this.

     I still hold my previous remark about wheel scroll and shift+wheel
     scroll doing the same thing when touchpad panning is enabled.
Instead,
     shift+wheel scroll could perform horizontal scrolling in touchpad
     panning mode.

     Regards,
     Orson

     On 01/16/2017 07:38 PM, Константин Барановский wrote:
     > Thank you, Wayne, for your response. I'm attached the checked
     patches.
     >
     > 2017-01-16 20:07 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx
     <mailto:stambaughw@xxxxxxxxx>>:
     >
     >> You are not being ignored.  I can't speak for all of the lead
     developers
     >> but I've been really busy so pretty much everyone has been getting
     >> ignored by me.  It's not intentional, it's just the reality of my
     >> current work load.
     >>
     >> Patch is giving me an unexpected eof with
3d_viewer-pan_step.patch.
     >>
     >> Did you address Bernhard's concern about the behavior of the GAL
     >> canvases as well as the legacy canvas?  I don't remember seeing
     anything
     >> but I may have missed it.
     >>
     >> On 1/16/2017 11:29 AM, Константин Барановский wrote:
     >>> Hello. I'm sorry for disturbing you, but I'm not understand
why my
     >>> messages are ignored. Proposed feature not needed for no one,
     except me?
     >>> Or I'm made something wrong? Please, give any comment.
     >>>
     >>> 2017-01-06 12:03 GMT+02:00 Константин Барановский
     >>> <baranovskiykonstantin@xxxxxxxxx
     <mailto:baranovskiykonstantin@xxxxxxxxx>
     <mailto:baranovskiykonstantin@xxxxxxxxx
     <mailto:baranovskiykonstantin@xxxxxxxxx>
     >>>> :
     >>>
     >>>     2016-11-23 0:22 GMT+02:00 Maciej Sumiński
     <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>
     >>>     <mailto:maciej.suminski@xxxxxxx
     <mailto:maciej.suminski@xxxxxxx>>>:
     >>>
     >>>         I could not apply the second patch, it gives me
     "unexpected end
     >>>         of file
     >>>         in patch" error. Would you verify the file?
     >>>
     >>>
     >>>      I downloaded both patches and checked them, they looks
     good for me.
     >>>     I do not got any problems or errors.
     >>>
     >>>
     >>
     >
     >
     >
     > _______________________________________________
     > Mailing list: https://launchpad.net/~kicad-developers
     <https://launchpad.net/%7Ekicad-developers>
     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
     > Unsubscribe : https://launchpad.net/~kicad-developers
     <https://launchpad.net/%7Ekicad-developers>
     > More help   : https://help.launchpad.net/ListHelp
     <https://help.launchpad.net/ListHelp>
     >



     _______________________________________________
     Mailing list: https://launchpad.net/~kicad-developers
     <https://launchpad.net/%7Ekicad-developers>
     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
     Unsubscribe : https://launchpad.net/~kicad-developers
     <https://launchpad.net/%7Ekicad-developers>
     More help   : https://help.launchpad.net/ListHelp
     <https://help.launchpad.net/ListHelp>




_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Follow ups

References