← Back to team overview

kicad-developers team mailing list archive

Re: Dialog SetFocus patches for OSX

 

it seems this is just as broke with or without the patch so this patch
can be pushed, will need to check into why its stealing focus on mouse
over though

On 24 January 2017 at 04:01, Simon Wells <swel024@xxxxxxxxx> wrote:
> Just a comment on the pad properties dialog, it works fine on init but
> the field loses focus when i mouse over the "preview" part of the
> dialog... is there a way to prevent this? (it should really only lose
> focus if someone clicks in the preview area) although i am unsure of
> the intricacies of wx and osx as to whether you unfocused zooming and
> panning and such work.
>
> On 23 January 2017 at 12:34, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> Would one of our osx devs test these patches and let me know if I should
>> commit them.  I don't see any coding policy violations so as long as
>> they fix the problems on osx then I will commit them.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 1/22/2017 5:52 PM, Diogo Condeço wrote:
>>> Hi all,
>>>
>>> I've attached 2 patches for some SetFocus optimisations on Macos. Tested
>>> also on Linux where there wasn't the issue, and it is still ok. This was
>>> a macos specific problem...
>>>
>>> 0001 fixes the find dialog and pad_properties dialog on pcbnew
>>> 0002 fixes add_component dialog on eeschema
>>>
>>> I've used the recommended wxFB3.5-RC1
>>> (https://github.com/marekr/wxFormBuilder.git
>>> <https://github.com/marekr/wxFormBuilder.git>) to modify the dialogs.
>>> Which isn't also working on macos making it hard to use it...
>>>
>>>
>>>
>>> --
>>> Diogo Condeço
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References