kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Thank you Alejandro.  The refactoring looks good and the unit tests are
a nice touch.  Since this patch is rather large, it might be worthwhile
pushing this to a new branch in you own development repo on launchpad so
other devs can clone it or merge it into there own development repos.

Developers, please review and test this patch as thoroughly as possible
and give feedback to Alejandro.  Once we are comfortable that it is good
to go, we can merge it into master.

I probably wont get time to review it this week since I'm leaving for
FOSDEM Thursday.  I will try to get to it as soon as possible after I
get back.

Cheers,

Wayne

On 1/30/2017 8:33 AM, Alejandro Garcia Montoro wrote:
> Whoops, sorry, wrong patches.
> 
> These are the ones.
> 
> 2017-01-30 13:57 GMT+01:00 Alejandro Garcia Montoro
> <alejandro.garciamontoro@xxxxxxxxx
> <mailto:alejandro.garciamontoro@xxxxxxxxx>>:
> 
>     Hi!
> 
>     I finally managed to refactor all code from
>     polygon/PolyLine.{h,cpp}, yay!
> 
>     The first patch (which is quite long) contains all the refactoring
>     and its propagated changes, whereas the second adds some tests to
>     qa/ in order to check that the new code is consistent with the old one.
> 
>     The major changes are on shape_poly_set.{h,cpp}, where the
>     refactored methods are added. There are also major changes on
>     class_zone.{h,cpp}, as the zone representation has changed from
>     CPolyLine to SHAPE_POLY_SET. A bunch of loops in several files,
>     which iterate through the vertices or segments of the polygons are
>     simplified using the family of ITERATOR classes, based on the
>     previous work of Tomasz.
> 
>     This patch could potentially break *a lot* of things, so it would be
>     great if you could play around and check that everything remains the
>     same. I've only tested the changes on Linux; tests on Windows are on
>     the way, but I have no access to an OSX machine, so I definitely
>     need some help there.
> 
>     Any comments are more than welcome.
> 
>     Thanks to the CERN guys for all the help :)
> 
>     Best,
>     Alejandro
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>