kicad-developers team mailing list archive

[Simon Richter <Simon.Richter@xxxxxxxxxx>]

Hi,

On 31.01.2017 20:13, Chris Pavlina wrote:

> /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member function ‘virtual bool DIALOG_EDIT_ONE_FIELD::TransferDataToWindow()’:
> /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>          if ( m_text.find_first_of( '?' ) != -1 )
>                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~

> wxString::find_first_of returns size_t, so that comparison will always
> be false.

Hmm, probably all instances of -1 should be wxString::npos instead?

   Simon

Attachment: signature.asc
Description: OpenPGP digital signature