kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

Oliver,

Thanks for looking at this.  I was trying to find time to look at this
today but the airline has made a complete mess of things so all of my
between flight time has been spent at customer service. :(  I'll try too
look at your patch if I have time between flights.

Sorry everyone for being out of the loop but I was getting pulled in 50
directions at FOSDEM so I hardly had time to even fire up my laptop.
Please be patient.  I'll try to catch up this week.

Cheers,

Wayne

On 2/6/2017 2:19 AM, Oliver Walters wrote:
> After further investigation, pressing the HK_MIRROR_Y and HK_MIRROR_X
> keys (whilst moving an item) also cause it to be removed.
> 
> I have attached a patch that addresses this, and provides a fix for the
> issues outlined in the previous message.
> 
> 
> 
> On Sun, Feb 5, 2017 at 11:11 PM, Oliver Walters
> <oliver.henry.walters@xxxxxxxxx <mailto:oliver.henry.walters@xxxxxxxxx>>
> wrote:
> 
>     The fix for lp:1660875 has introduced a bug into nightly and stable
> 
>     Nightly: 9319ef034dbf0421ebbd2c78f7ee41f01bb56c0c
>     Stable: d1f8dbb9debe128ddd015edb1ff0fa954a8a08a7
> 
>     Bug:
>     When moving a pin around in libedit, pressing HK_EDIT or HK_ROTATE
>     will delete the currently selected pin (designated m_drawItem). This
>     is undesired behaviour.
> 
>     This bug has been caused by removing the check to see if m_drawItem
>     is non-null (i.e. there is an item currently being moved). 
> 
>     The referenced patches do not change much so it is easy to spot the
>     bug. I have not attached a patch to fix this as the previous
>     definition of /bool itemInEdit/ has been changed, and does not seem
>     to be sufficient as a test for whether an item is currently being
>     moved around the screen.
> 
>     I shall defer to Wayne who made this patch and better understands
>     the subtleties of what has been done.
> 
>     Cheers,
>     Oliver
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>