kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Chris,

I had a chance to review the new footprint selector.  I like it so far
although it does seem a bit cramped with both preview window.  I'm not
sure there is much you can do about that.  I'm fine with you pushing
what you have done so far.

I do have one comment.  It it necessary to open the symbol viewer on a
left click in the symbol panel?  My initial instinct was to click on the
panel to set the focus to zoom and/or pan the symbol in the panel to get
a better view.  Maybe launching the symbol viewer should occur on a
double click.  Just food for thought.

I didn't get a chance to review the code but one thing I want to make
sure is that you are not adding UI code to any of the symbol or
footprint library objects.  The recent progress dialog patch added UI
code to the PART_LIBS object.  We (I) spent a lot of time uncoupling the
symbol library code from all things UI and now that has been undone.
I'll fix this when I implement the symbol library table.

Cheers,

Wayne

On 2/11/2017 9:07 PM, Chris Pavlina wrote:
> And, it's in the branch now, temporarily gated by build option
> KICAD_FOOTPRINT_SELECTOR. At the moment it is VERY rudimentary, by which
> I mean it doesn't work - the preview is stuck showing one particular
> footprint permanently, and it's one you probably don't have in your
> libraries...
> 
> Hopefully this will be fixed tomorrow. Wayne, my current goal is this:
> tomorrow, I will have footprint preview working completely, but still no
> footprint *selection*. At this point, I'd really like to push what I
> have, so that the footprint preview and the other GUI improvements in
> the component selector get further testing. Then, I will work on adding
> footprint selection, followed by 3D preview, both of which can be merged
> as separate patches. Have you had a chance to review yet?
> 
> On Sat, Feb 11, 2017 at 08:12:17PM -0500, Chris Pavlina wrote:
>> This bit is not in the branch yet, but here's a little preview...
>>
>> https://misc.c4757p.com/i-can-footprint.png
>>
>> Thanks Tom!
>>
>> On Mon, Feb 06, 2017 at 09:07:16PM -0500, Chris Pavlina wrote:
>>> Preview at git@xxxxxxxxxx:cpavlina/kicad branch componentchooser.
>>> Footprint part still pending.
>>>
>>> On Sun, Feb 05, 2017 at 09:52:03PM -0500, Chris Pavlina wrote:
>>>> Still very early... I call it "componentchoosernew"
>>>>
>>>> https://misc.c4757p.com/componentchoosernew.png
>>>>
>>>> -- 
>>>> Chris
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>