← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] kicad: tree_project_frame: fixup drawframe style

 

Le 19/02/2017 à 00:00, Clemens Koller a écrit :
> Thank you... I'll manage on my own, what's merged, then.
> 
> I do test my stuff on Linux/X11/XFCE for now. Testing for Win7 is possible on request.
> 
> Clemens
> 
>>>> On 2017-02-08 22:13, Clemens Koller wrote:
>>>>> wxNO_BORDER and wxSW_3D seem incompatible and the border flickers
>>>>> when the tree frame gets resized. Using KICAD_DEFAULT_DRAWFRAME_STYLE
>>>>> avoids this.
>>>>>

Hi Clemens,

Using KICAD_DEFAULT_DRAWFRAME_STYLE as style for a wxSashLayoutWindow is incorrect.
wxSashLayoutWindow is not a wxFrame, and is not derived from it.

The allowed styles are here:
http://docs.wxwidgets.org/3.1/classwx_sash_window.html

wxNO_BORDER is a no op flag and do nothing (It should not be used here).

perhaps wxSW_3D creates issues with your Window manager (I do not have issues on W7 and Linux/KDE,
whatever the style being used).

Could you have a look at this issue, and fix it to avoid using the incorrect
KICAD_DEFAULT_DRAWFRAME_STYLE style for a wxSashLayoutWindow .

It is a potential bug although I did not notice an issue when using it.
However, I am unable to know the actual style of this wxSashLayoutWindow.

Thanks.


-- 
Jean-Pierre CHARRAS


Follow ups

References