kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

Sorry - ignore my previous post. The patch results in filename
duplication in the Windows file browser. I'm working on a different
fix.

- Cirilo

On Wed, Feb 22, 2017 at 7:55 AM, Cirilo Bernardo
<cirilo.bernardo@xxxxxxxxx> wrote:
> Thanks Jean-Pierre,
>
>  That gives me a good idea of where to look. Your patch is
> good and should be applied. In the 3D cache manager the
> file extensions are checked against the list provided by each
> plugin; since I wasn't including the upper-case names in
> Windows I suspect that's where it failed.
>
> - Cirilo
>
>
> On Tue, Feb 21, 2017 at 10:52 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>> Le 21/02/2017 à 09:02, Cirilo Bernardo a écrit :
>>> Hi folks,
>>>
>>>  A number of STEP related bugs have been reported and at this point in
>>> time I suspect the problems have something to do with character
>>> translations.
>>>
>>> Bug 1:  On Windows, STEP files with non-ASCII characters in the path
>>> are not correctly processed by the 3D plugin.  In this case all code is
>>> running within one process and I believe I have a fix.
>>>
>>> Bug 2: On Windows files with the extension "STEP" don't seem to load.
>>> I'm not sure what's going on here yet; I need to read up on a few
>>> wx widgets.
>>>
>>> Bug 3: Well, no one has reported such a bug yet, but the underlying
>>> problem with Bug 1 should also affect the external kicad2step tool,
>>> but only on Windows.
>>>
>>> Has anyone observed such bugs and have anything to add?
>>>
>>> - Cirilo
>>
>> Hi Cirilo,
>>
>> I am thinking there are 2 bugs, not only one in plugins code.
>>
>> The first is related to the way the extensions are analyzed in the code.
>> The code consider only the ext in lower case on Windows. I am suspecting there are somewhere case
>> sensitive comparisons in code.
>>
>> Just consider Windows platform and Unix platforms are the same to fix this issue (attached a short
>> patch just as proof of this assertion).
>> The code will be simpler and more reliable.
>> It has also the advantage to be the same (showing the same dialogs and same messages) on all platforms.
>>
>> The second is related to non ASCII filenames.
>> This is a different bug, not fixed by my short patch.
>>
>> Thanks.
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>