kicad-developers team mailing list archive

[Robbert Lagerweij <rlagerweij@xxxxxxxxxxx>]

Hi, sorry for that.

It is indeed a stray ">"  which is a remnant of a last minute edit to remove a   "this->“ coding style violation. I'll send the corrected version of the patch later today.

Robbert

Get Outlook for Android<https://aka.ms/ghei36>


From: firewalker
Sent: Monday, February 27, 11:33
Subject: Re: [Kicad-developers] [Patch] Add an option to select a reference point and an anchor in pcbnew move exactly dialog
To: Robbert Lagerweij
Cc: KiCad Developers

I tried the patch with revision 799c8b692. I got the error bellow.

[ 90%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface.dir/modedit_onclick.cpp.o
/koko/kicad-git/src/kicad/pcbnew/modedit.cpp: In member function ‘void FOOTPRINT_EDIT_FRAME::moveExact()’:
/koko/kicad-git/src/kicad/pcbnew/modedit.cpp:861:34: error: expected primary-expression before ‘>’ token
             final_move_vector += >GetScreen()->m_O_Curseur - anchorPoint;
                                  ^
make[2]: *** [pcbnew/CMakeFiles/pcbnew_kiface.dir/build.make:4500: pcbnew/CMakeFiles/pcbnew_kiface.dir/modedit.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1506: pcbnew/CMakeFiles/pcbnew_kiface.dir/all] Error 2
make: *** [Makefile:150: all] Error 2

On Sun, Feb 26, 2017 at 8:09 PM, Robbert Lagerweij <rlagerweij@xxxxxxxxxxx<mailto:rlagerweij@xxxxxxxxxxx>> wrote:

Hi,

Please find attached a patch to address a wish list item on launchpad (lp:1460460).

This patch adds a radiobox to the Move Exactly dialog to allow the user to select a  reference point for the move. The additional options are: User Origin (set with <space>), Grid Origin and Sheet Origin (effectively making it an absolute coordinate). The default behavior is unchanged (i.e. any values entered into the text controls will be interpreted as a move relative to the current position).

In addition, a checkbox is added (where it makes sense, hidden elsewhere) to allow overriding which point within the component is put on top of the designated coordinate. By default this is the anchor point of the component as defined in the library. The additional options are the Top Left Pad of the footprint and the Center of the footprint. These options are provided to allow for consistent placement of various footprints with inconsistent default anchors. If multiple items are selected, the default behavior is to place the center of the selection over the designated coordinate. Checking the "override" checkbox changes this to the top leftmost pin (of the top leftmost footprint) or center of the top leftmost footprint (if there are any footprints in the selection).

This patch has been tested on linux only, but does not contain any platform specific code. Sorry for the large diff from the wxformbuilder file.

Kind regards,

Robbert

* https://bugs.launchpad.net/kicad/+bug/1460460

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx<mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp