kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

On Wed, Mar 1, 2017 at 11:40 PM, Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:
>
> color_swatch.cpp uses std::unique_ptr

Hi Simon,

This must be because the compiler (MSVC on Jenkins) has set
__cplusplus to something other than 201103L, so include/make_unique.h
isn't doing the polyfill and also isn't including <memory>. Perhaps
<memory> should be included in include/common.h, at the same time as
make_unique.h, so that when compilers provide their own make_unique,
<memory> is also included? Then C++14 and C++11 compiler will work
identically in this regard.

Otherwise, it's very easy to forget a <memory> and only find breakage
much later on Jenkins under MSVC (like now!)

Cheers,

John