kicad-developers team mailing list archive
Mailing list archive
Re: Layer ID enums
Maciej Suminski <maciej.suminski@xxxxxxx>
Sun, 12 Mar 2017 20:36:06 +0100
spf=pass (sender IP is 18.104.22.168) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
I would not mind changing the current way of handling the GAL layers.
They have not been put in the default layers enum, because the dedicated
GAL layers are virtual, in the sense they are only to display certain
objects (e.g. net names). I did not want to clutter the real layers set,
so they are separated.
If you see a way to simplify the code, please proceed. You have already
proved many times that you know the C++ coding art.
On 03/12/2017 05:25 PM, Jon Evans wrote:
> Can anyone explain if there is a reason why the layer definition enums are
> done in the way they are?
> Using multiple enums for the "normal" layers and the GAL extra layers is
> complicating the code, especially now that I am using the GAL layers for
> GerbView, and also working on a color theme manager that will be shared
> across applications.
> It would make more sense to me if there was a single large enum that
> contained all possible layers, with some offset somewhere to separate the
> "drawing" layers from the "GAL item" layers. This would simplify code that
> needs to refer to layer IDs across multiple applications.
> Would anyone be opposed to this?
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp