← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Reusable GAL options panel


Hey John,

I like these changes but I noticed one minor coding policy issue.  The
macro _("") should be formatted as _( "" ).  I'm willing to commit the
patches as is and you can send a patch to fix the coding policy issues
or you can revise the patches.  I'm fine either way.



On 3/13/2017 12:35 PM, John Beard wrote:
> Hi,
> Here is a patch set for a reusable GAL options panel, which allows any
> GAL-aware program to set the GAL options in a dialog easily.
> This includes a new dialog for Modedit that uses the new panel,
> closing the bug about not being able to change Modedit grid type.
> Gerbview's new GAL mode should be able to use this too.
> Third patch is a quick refactor for the Pcbnew display prefs panel,
> which removes the old manual event handling and uses
> TransferDataTo/FromWindow instead.
> Cheers,
> John
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups