kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi Wayne,

Thanks for pushing. I don't see that in GTK+, but I'm told the
attached patch should do the right thing.

These flags haven't been changed from the wxFB - was it also broken
before in Pcbnew?

Cheers,

John

On Thu, Mar 16, 2017 at 8:25 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> Hey John,
>
> I pushed your patches to the master branch.  Thanks.  One thing I
> noticed that I missed the first time around is the spin controls don't
> quite look right on windows (see attached image).  Would you please take
> a look at this when you get a chance?
>
> Thanks,
>
> Wayne
>
>
>
> On 3/16/2017 6:24 AM, John Beard wrote:
>> Hi Wayne,
>>
>> Sorry about that, missed it as converting from wxFB's internal formatting.
>>
>> Updated patch 0001.
>>
>> Cheers,
>>
>> John
>>
>> On Thu, Mar 16, 2017 at 12:45 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> Hey John,
>>>
>>> I like these changes but I noticed one minor coding policy issue.  The
>>> macro _("") should be formatted as _( "" ).  I'm willing to commit the
>>> patches as is and you can send a patch to fix the coding policy issues
>>> or you can revise the patches.  I'm fine either way.
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 3/13/2017 12:35 PM, John Beard wrote:
>>>> Hi,
>>>>
>>>> Here is a patch set for a reusable GAL options panel, which allows any
>>>> GAL-aware program to set the GAL options in a dialog easily.
>>>>
>>>> This includes a new dialog for Modedit that uses the new panel,
>>>> closing the bug about not being able to change Modedit grid type.
>>>>
>>>> Gerbview's new GAL mode should be able to use this too.
>>>>
>>>> Third patch is a quick refactor for the Pcbnew display prefs panel,
>>>> which removes the old manual event handling and uses
>>>> TransferDataTo/FromWindow instead.
>>>>
>>>> Cheers,
>>>>
>>>> John
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp

From f1c3995b7e71e7948abb33fbbb5eaa0b1507b2cf Mon Sep 17 00:00:00 2001
From: John Beard <john.j.beard@xxxxxxxxx>
Date: Thu, 16 Mar 2017 22:39:05 +0800
Subject: [PATCH] Fix GAL display properties spin buttons on Windows

---
 common/widgets/gal_options_panel.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/widgets/gal_options_panel.cpp b/common/widgets/gal_options_panel.cpp
index fa62fe653..e18746d07 100644
--- a/common/widgets/gal_options_panel.cpp
+++ b/common/widgets/gal_options_panel.cpp
@@ -132,7 +132,7 @@ GAL_OPTIONS_PANEL::GAL_OPTIONS_PANEL( wxWindow* aParent, KIGFX::GAL_DISPLAY_OPTI
 
         m_gridLineWidthSpinBtn = new wxSpinButton( sGridSettings->GetStaticBox(),
                 wxID_ANY, wxDefaultPosition, wxDefaultSize, wxSP_ARROW_KEYS );
-        sGridSettingsGrid->Add( m_gridLineWidthSpinBtn, 0, wxALL, 0 );
+        sGridSettingsGrid->Add( m_gridLineWidthSpinBtn, 0, wxEXPAND | wxALL, 0 );
 
         l_gridLineWidthUnits = new wxStaticText( sGridSettings->GetStaticBox(),
                 wxID_ANY, _("px"), wxDefaultPosition, wxDefaultSize, 0 );
@@ -150,7 +150,7 @@ GAL_OPTIONS_PANEL::GAL_OPTIONS_PANEL( wxWindow* aParent, KIGFX::GAL_DISPLAY_OPTI
 
         m_gridMinSpacingSpinBtn = new wxSpinButton( sGridSettings->GetStaticBox(),
                 wxID_ANY, wxDefaultPosition, wxDefaultSize, wxSP_ARROW_KEYS );
-        sGridSettingsGrid->Add( m_gridMinSpacingSpinBtn, 0, wxALL, 0 );
+        sGridSettingsGrid->Add( m_gridMinSpacingSpinBtn, 0, wxEXPAND | wxALL, 0 );
 
         l_gridMinSpacingUnits = new wxStaticText( sGridSettings->GetStaticBox(),
                 wxID_ANY, _("px"), wxDefaultPosition, wxDefaultSize, 0 );
-- 
2.12.0