← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Zoom to fit on empty canvas


Hi John, JP,

I will take a look at how this would work with GerbView, hopefully later
There is no worksheet item in GerbView, so we might want a more abstract
idea of what the "default view" should be.

For the units question, for sure this needs to be resolved, I don't have
suggestions yet until I look at the code some more.  But, I would think it
makes sense for GAL to work on one units system across all applications,
and code in common to use that units system also, and then it is up to
applications to scale things when they insert them into GAL views.


On Thu, Mar 16, 2017 at 2:03 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 16/03/2017 à 11:21, John Beard a écrit :
> > Hi JP,
> >
> > Thank for checking this. Internal units always confuse me, since
> > they're always different and nothing in common can ever use anything
> > to do with IUs, as they're only defined in some end executables.
> >
> > How should this be done correctly?
> >
> > Cheers,
> >
> > John
> >
> IUs are not very easy to handle, and currently I am not very happy by the
> way they are handled.
> About the GAL layer, sorry, but I am not a GAL specialist.
> However I just know this issue is serious and must be solved.
> Until now, GAL was used only by Pcbnew.
> Unfortunately, in a few places, I saw a conversion to nanometers using
> fixed scaling factor.
> (A golden advice I learned when writing Kicad code: do not use a fixed
> scaling factor in code)
> Now GAL is very near to be used by other applications.
> Conversion to nanometers just by using a fixed scaling factor is therefore
> a bug, and from my point
> of view, even in Pcbnew.
> Who know: we could change one day the internal unit value. It already
> happened.
> I just leave guys who have a good knowledge of the GAL code taking the
> best decision.
> Thanks, John.
> --
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp