kicad-developers team mailing list archive

[José Ignacio <jose.cyborg@xxxxxxxxx>]

I do not thing such option is necessary, the amount of broken files is not
that high, and the dialog will not show up once if you fix them.

On Fri, Mar 31, 2017 at 8:44 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> I've already fixed this with option #3.  I will go back and add a do not
> show again option when I get some time.  I really wanted get this fix
> committed as quickly as possible to minimize the number of broken
> schematics.
>
> Cheers,
>
> Wayne
>
> On 3/31/2017 9:40 AM, José Ignacio wrote:
> > I like option #3 the most, #1 a close second, #4 the least, i wouldn't
> > like unexpected automatic saving behavior. If anything it may be worth
> > it to have a generic thing were to toss all these warts in the future.
> > Perhaps a general "file repair/recovery", kind of how the rescue system
> > works for symbols.
> >
> > On Fri, Mar 31, 2017 at 12:38 AM, David Godfrey <info@xxxxxxxxxxx
> > <mailto:info@xxxxxxxxxxx>> wrote:
> >
> >     Hi,
> >
> >     I'd vote of #3 but with the addition of a "Don't show this dialog in
> the
> >     future" option.
> >     If the "don't show" has been set, then simply auto save (ie: #4)
> >
> >     Regards
> >
> >     David G
> >
> >
> >     On 31/03/17 01:33, Wayne Stambaugh wrote:
> >     > I have found and fixed the bug in this bug report:
> >     >
> >     > https://bugs.launchpad.net/kicad/+bug/1677282
> >     <https://bugs.launchpad.net/kicad/+bug/1677282>
> >     >
> >     > This bug creates invalid schematic files which sets the component
> unit
> >     > flag to 0 and breaks the netlist generator.  The fix itself is
> simple.
> >     > What is not simple is what to do about the invalid schematic files
> >     that
> >     > have already been created.  I added code to schematic parser to
> >     fix this
> >     > but this creates a dilemma.  Technically the schematic is modified
> >     which
> >     > begs the question, what to do next.  None of the following choices
> are
> >     > particularly appealing:
> >     >
> >     > 1) Do nothing and leave the file in an invalid status until the
> next
> >     > time the user saves the schematic.  This is probably the most
> >     convenient
> >     > but what about broken schematics being used by versions of kicad
> prior
> >     > to this fix?
> >     >
> >     > 2) Set the schematic modified status which will trigger a save
> warning
> >     > when eeschema is closed even if the user hasn't made any changes.
> We
> >     > already do this with SCH_SCREEN::SchematicCleanUp() that gets
> called
> >     > lots of places outside of schematic editing.  The problem with
> this is
> >     > that the user has no idea why they are getting a save warning when
> >     they
> >     > didn't actually change anything.
> >     >
> >     > 3) Set the schematic modified status and inform the user that
> >     there was
> >     > an error in their schematic file that was repaired on load and
> >     requires
> >     > saving.  This is the most informative for the user but reeks of
> >     nagware.
> >     >
> >     > 4) Silently save the corrected schematic with no user
> >     interaction.  This
> >     > will undoubtedly make VCS users unhappy.
> >     >
> >     > As much as I hate nagware, I like unexpected save warnings when I
> >     > haven't changed anything even less so I'm leaning towards option
> >     3.  Any
> >     > feedback would be appreciated.
> >     >
> >     > Thanks,
> >     >
> >     > Wayne
> >     >
> >     > _______________________________________________
> >     > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >     >
> >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>