kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #29128
Re: [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Thu, 13 Apr 2017 08:03:41 -0400
-
In-reply-to:
<CAHBNN+OKkcxqi9dDZhmrm8XrzJC6oK1XUs13_p_=NXHmpiudpw@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
Cirilo,
Thanks for the info. The second call to ReadName() does look a bit odd
so I can understand Konrad's confusion.
Cheers,
Wayne
On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
> Do not accept this patch, it will break the parser. The statement
> which was removed is not redundant.
>
> - Cirilo
>
> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
> <konrad.beckmann@xxxxxxxxx> wrote:
>> ---
>> plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References