← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

 

Hi!

These lines scream for some comments in the source...
I wouldn't get it, too.

Regards,

Clemens

On 2017-04-13 14:03, Wayne Stambaugh wrote:
> Cirilo,
> 
> Thanks for the info.  The second call to ReadName() does look a bit odd
> so I can understand Konrad's confusion.
> 
> Cheers,
> 
> Wayne
> 
> On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
>> Do not accept this patch, it will break the parser. The statement
>> which was removed is not redundant.
>>
>> - Cirilo
>>
>> On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann
>> <konrad.beckmann@xxxxxxxxx> wrote:
>>> ---
>>>  plugins/3d/vrml/v2/vrml2_base.cpp | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References