kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 10/04/2017 à 10:44, Tomasz Wlostowski a écrit :
> On 10.04.2017 09:18, jp charras wrote:
>> Le 10/04/2017 à 08:39, Nick Østergaard a écrit :
>>> Hi JP,
>>>
>>> Yes I can confirm that it seems to work now, but since you mentioned
>>> that it was not fixed properly yet, I thought it was worth
>>> highlighting in this thread. Are unittests missing here for the
>>> geometry library or is this on a higher level?
>>
>> About SEG class, unittests works.
>>
>> It is more the fact when using a SEG class, you can now modify an other entity without clearly
>> notice in your code the other entity will be modified, by side effect, because now the SEG class
>> stores a reference to the other entity, not a copy of values.
>>
>> It is this side effect I do not like.
> 
> Hi JP & Alessandro,
> 
> I agree that keeping references to the points in the SEG class is not
> the very best idea. I would roll back to the original SEG class.


OK.
I reverted the change in seg.h (looking to me as a old seg.h version committed by mistake)
in my commit cbb5708c365025df67161a7fa8e29b3925e39741,
and updated a few comments.



-- 
Jean-Pierre CHARRAS