kicad-developers team mailing list archive

[Oliver Walters <oliver.henry.walters@xxxxxxxxx>]

Thomas, et al,

I have attached _003 patch which now ensures that the "Save" button is
activated when you make changes in the table.

Please apply this on top of the other two and let me know if it fixes that
issue.

Thanks,
Oliver

On Sat, Apr 15, 2017 at 9:33 PM, Thomas Pointhuber <thomas.pointhuber@xxxxxx
> wrote:

> Hi Oliver,
>
> nice work, and I hope it get merged into master soon.
>
> Some issues I found so far (using your github branch):
>
> * References are not displayed correctly when using duplicated
> subschematics.
> * Search functionality (using Ctrl+F) does not work with collapsed
> grouped references
> * Even when the dialog says "Save and Close", it actually only writes
> the changes to the schematic. When you close the schematic you don't get
> a notification to save your work, as well as you are not able to click
> the save button when your only change was adjusting names of footprints
> using the component table viewer.
>
> Regards, Thomas
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

From 6cef9ed2702e12b9aadbbdfc7228155f1befb875 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@xxxxxxxxx>
Date: Sun, 16 Apr 2017 16:43:59 +1000
Subject: [PATCH] Mark schematic as dirty

Notify schematic of changes when window is closed
---
 eeschema/dialogs/dialog_bom_editor.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eeschema/dialogs/dialog_bom_editor.cpp b/eeschema/dialogs/dialog_bom_editor.cpp
index 12f77c6..f4b73b4 100644
--- a/eeschema/dialogs/dialog_bom_editor.cpp
+++ b/eeschema/dialogs/dialog_bom_editor.cpp
@@ -153,6 +153,8 @@ void DIALOG_BOM_EDITOR::OnBomEditorClosed( wxCloseEvent& event )
             m_bom->ApplyFieldChanges();
             m_parent->Refresh();
         }
+
+        m_parent->OnModify();
     }
 
     Destroy();
-- 
2.7.4