kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #29293
Re: [Feature] Position Relative to
-
To:
Russell Oliver <roliver8143@xxxxxxxxx>, "kicad-developers@xxxxxxxxxxxxxxxxxxx" <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
-
Date:
Fri, 28 Apr 2017 18:33:01 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.50) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CAEKH5oVOr_uh831PbO_WkEC=zf0FwgMhKHyN=Bv7GVE=jPtXkQ@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
On 28.04.2017 18:26, Russell Oliver wrote:
> Hello All,
>
> For the purpose of accurately placing components I have developed a
> relative positioning tool.
> Right clicking > Position Relative to or Control-R on selected items
> will bring up a dialog the same as the Move exact tool with a button for
> selecting another item, the 'achor'. Upon clicking OK the first
> selection is moved to a position relative to the anchor.
> The position of anchor item is also displayed.
>
> Attached is the patch.
>
> Any comments on the functionality or code quality would be appreciated.
>
Hi Russell,
Thanks for the patch. Few comments:
- please follow the coding style rules,
- don't use wxPoints/wxSizes in the tool code (if not for the purpose of
interfacing with the BOARD_ITEMs).
Cheers,
Tom
> Regards
> Russell Oliver
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
