kicad-developers team mailing list archive

[Russell Oliver <roliver8143@xxxxxxxxx>]

Hi Tom,

I'll check it against the code style rules to see what I could improve on.
With regards to the not using wxPoints in the tool code I have used the
MoveExact action of the edit tool as my template which uses the wxPoint
quite often, and more broadly it is used throughout the Edit tool. Going
forward is the use of the VECTOR2I type preferred for coordinates?

Regards
Russell

On Sat, Apr 29, 2017 at 2:33 AM Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
wrote:

> On 28.04.2017 18:26, Russell Oliver wrote:
> > Hello All,
> >
> > For the purpose of accurately placing components I have developed a
> > relative positioning tool.
> > Right clicking > Position Relative to or Control-R on selected items
> > will bring up a dialog the same as the Move exact tool with a button for
> > selecting another item, the 'achor'. Upon clicking OK the first
> > selection is moved to a position relative to the anchor.
> > The position of anchor item is also displayed.
> >
> > Attached is the patch.
> >
> > Any comments on the functionality or code quality would be appreciated.
> >
>
> Hi Russell,
>
> Thanks for the patch. Few comments:
> - please follow the coding style rules,
> - don't use wxPoints/wxSizes in the tool code (if not for the purpose of
> interfacing with the BOARD_ITEMs).
>
> Cheers,
> Tom
>
> > Regards
> > Russell Oliver
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>