kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 17/06/2017 à 13:38, Fabrizio Tappero a écrit :
> Hi guys,
> I'd like to reminder that this patch is still pending. I would love it to be applied.
> 
> cheers
> Fabrizio

Hi Fabrizio,

Sorry to say that, but you cannot move this icon without changing the associated code.
Unlike icons in vertical toolbar, this icon, like all icons of the vertical right toolbar, is a
wxITEM_CHECK tool (and unlike tools of the main upper toolbar).

To tell the truth, I am not especially thrilled by your proposal, because this icon does not act as
the hierarchy navigator icon in main toolbar, but like any other tool icon of the vertical right
toolbar (It changes the properties of the left click mouse button and the shape of the mouse cursor).

For instance, after moving the Zoom on selection tool from vertical toolbar to main toolbar, I spent
2 days to fix UI issues created by this change.
Just because the associated code was designed to manage tools of the vertical toolbar, not for any
tool in any toolbar, both in legacy canvas and gal canvas, and was not fixed by the initial patch.


> 
> 
> 
> On Thu, Jun 8, 2017 at 10:03 AM, Fabrizio Tappero <fabrizio.tappero@xxxxxxxxx
> <mailto:fabrizio.tappero@xxxxxxxxx>> wrote:
> 
>     Hello,
>     I moved the hierarchy navigator icon next to the other two hierarchy icons to make the toolbar
>     more coherent. 
> 
>     Inline image 1
> 
>     I think the hierarchy navigator window, activated by the first hierarchy icon, has a bigger
>     margin so that scrollbar is not show (see below) but I could not find a way to do that. Maybe
>     some wxwidget person can advise.
> 
>     Inline image 2
> 
>     cheers
>     Fabrizio
> 
> 
> 
> 
> 
> 
> 
>     From 6ffa93414e2076dc048769eee48581abcb2f1634 Mon Sep 17 00:00:00 2001
>     From: Fabrizio Tappero <fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@xxxxxxxxx>>
>     Date: Thu, 8 Jun 2017 09:56:25 +0200
>     Subject: [PATCH] hierarchy navigator icon moved where it belongs
> 
>     ---
>      eeschema/tool_sch.cpp | 11 +++++------
>      1 file changed, 5 insertions(+), 6 deletions(-)
> 
>     diff --git a/eeschema/tool_sch.cpp b/eeschema/tool_sch.cpp
>     index 78e0179..f872592 100644
>     --- a/eeschema/tool_sch.cpp
>     +++ b/eeschema/tool_sch.cpp
>     @@ -130,11 +130,14 @@ void SCH_EDIT_FRAME::ReCreateHToolbar()
>          m_mainToolBar->AddSeparator();
>      
>          m_mainToolBar->AddTool( ID_HIERARCHY, wxEmptyString, KiBitmap( hierarchy
>     _nav_xpm ),
>     -                            _( "Navigate schematic hierarchy" ) );
>     +                            _( "Show sheet hierarchy window" ) );
>      
>      
>          m_mainToolBar->AddTool( ID_POPUP_SCH_LEAVE_SHEET, wxEmptyString, KiBitma
>     p( leave_sheet_xpm ),
>     -                            _( "Leave sheet" ) );
>     +                            _( "Jump to master sheet" ) );
>     +
>     +    m_mainToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString, KiBit
>     map( hierarchy_cursor_xpm ),
>     +                            _( "Navigate sheet hierarchy" ), wxITEM_CHECK );
>      
>          m_mainToolBar->AddSeparator();
>      
>     @@ -201,10 +204,6 @@ void SCH_EDIT_FRAME::ReCreateVToolbar()
>          m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString, KiBitmap( net_highl
>     ight_schematic_xpm ),
>                                  _( "Highlight net" ), wxITEM_CHECK );
>      
>     -    m_drawToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
>     -                            KiBitmap( hierarchy_cursor_xpm ),
>     -                            _( "Ascend/descend hierarchy" ), wxITEM_CHECK );
>     -
>          m_drawToolBar->AddTool( ID_SCH_PLACE_COMPONENT, wxEmptyString, KiBitmap(
>      add_component_xpm ),
>                                  HELP_PLACE_COMPONENTS, wxITEM_CHECK );
>      
>     -- 
>     2.7.4
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS