← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] hierarchy navigator icon moved where it belongs

 

Hi guys,
I'd like to reminder that this patch is still pending. I would love it to
be applied.

cheers
Fabrizio



On Thu, Jun 8, 2017 at 10:03 AM, Fabrizio Tappero <
fabrizio.tappero@xxxxxxxxx> wrote:

> Hello,
> I moved the hierarchy navigator icon next to the other two hierarchy icons
> to make the toolbar more coherent.
>
> [image: Inline image 1]
>
> I think the hierarchy navigator window, activated by the first hierarchy
> icon, has a bigger margin so that scrollbar is not show (see below) but I
> could not find a way to do that. Maybe some wxwidget person can advise.
>
> [image: Inline image 2]
>
> cheers
> Fabrizio
>
>
>
>
>
>
>
> From 6ffa93414e2076dc048769eee48581abcb2f1634 Mon Sep 17 00:00:00 2001
> From: Fabrizio Tappero <fabrizio.tappero@xxxxxxxxx>
> Date: Thu, 8 Jun 2017 09:56:25 +0200
> Subject: [PATCH] hierarchy navigator icon moved where it belongs
>
> ---
>  eeschema/tool_sch.cpp | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/eeschema/tool_sch.cpp b/eeschema/tool_sch.cpp
> index 78e0179..f872592 100644
> --- a/eeschema/tool_sch.cpp
> +++ b/eeschema/tool_sch.cpp
> @@ -130,11 +130,14 @@ void SCH_EDIT_FRAME::ReCreateHToolbar()
>      m_mainToolBar->AddSeparator();
>
>      m_mainToolBar->AddTool( ID_HIERARCHY, wxEmptyString, KiBitmap(
> hierarchy
> _nav_xpm ),
> -                            _( "Navigate schematic hierarchy" ) );
> +                            _( "Show sheet hierarchy window" ) );
>
>
>      m_mainToolBar->AddTool( ID_POPUP_SCH_LEAVE_SHEET, wxEmptyString,
> KiBitma
> p( leave_sheet_xpm ),
> -                            _( "Leave sheet" ) );
> +                            _( "Jump to master sheet" ) );
> +
> +    m_mainToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
> KiBit
> map( hierarchy_cursor_xpm ),
> +                            _( "Navigate sheet hierarchy" ), wxITEM_CHECK
> );
>
>      m_mainToolBar->AddSeparator();
>
> @@ -201,10 +204,6 @@ void SCH_EDIT_FRAME::ReCreateVToolbar()
>      m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString, KiBitmap(
> net_highl
> ight_schematic_xpm ),
>                              _( "Highlight net" ), wxITEM_CHECK );
>
> -    m_drawToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
> -                            KiBitmap( hierarchy_cursor_xpm ),
> -                            _( "Ascend/descend hierarchy" ), wxITEM_CHECK
> );
> -
>      m_drawToolBar->AddTool( ID_SCH_PLACE_COMPONENT, wxEmptyString,
> KiBitmap(
>  add_component_xpm ),
>                              HELP_PLACE_COMPONENTS, wxITEM_CHECK );
>
> --
> 2.7.4
>
>

PNG image

PNG image


Follow ups

References