← Back to team overview

kicad-developers team mailing list archive

Ugly hack in LIB_VIEW_FRAME


The following is in LIB_VIEW_FRAME (viewlib_frame.h specifically):

    // TODO(hzeller): looks like these members were chosen to be static to survive different
    // instances of this browser and communicate it to the next instance. This looks like an
    // ugly hack, and should be solved differently.
    static wxString m_libraryName;

    static wxString m_entryName;

Is this a feature anyone needs? I can't see why the browser has to
remember its list selection across instances. Will anyone miss this if I
just make them non-static?


Follow ups