kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #30128
Re: [PATCH] - Improved error messages
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Mon, 24 Jul 2017 13:19:45 -0400
-
In-reply-to:
<CAMfgvU_fhXj=XE=U+ggYp9nQAZkFYbyC=EYLiGL5AZj3KOD6WQ@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
Oliver,
I finally got a chance to look at these patches and they seem fine to
me. I am willing to commit them as is if there are no other objections.
One minor note. I don't know if this was intentional or not but please
use normal sentence punctuation in dialog messages. You managed to
remove some of the previously valid punctuation.
Cheers,
Wayne
On 7/20/2017 10:16 AM, Oliver Walters wrote:
> A lot of the error messages presented to the users are full of
> developer-only data, that often serves to confuse rather than help end
> users. However the developer data is great for bug reports and dev feedback.
>
> I have updated the DisplayErrorMessage and DisplayInfoMessage functions
> to have an extra information parameter, which is initially hidden in a
> "Show details" drop-down box.
>
> I have not fixed all the error messages. However I have updated a few to
> start the ball rolling. In particular I have focused on messages that I
> have seen and thought to be unhelpful.
>
> I think that following this pattern can provide better UX when errors
> occur, and improve the professional look of KiCad.
>
> Patch set attached.
>
> Regards,
> Oliver
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References