kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I'm not sure about this myself.  I took a look at the code and I still
don't fully understand why there are multiple options.

The ID_MENU_ARCHIVE_MODULES_IN_LIBRARY command appears to only allow you
to save the footprints in the current board to a library already listed
in the footprint library table.  I'm not sure this is necessary since
you could easily select an existing pretty footprint library (in the
footprint library table or otherwise) and overwrite it without limiting
the choices to the footprint library table.  The best description I can
think of for this is "Archive Footprints in Footprint Library Table
Entry".  This would a least be accurate.

The ID_MENU_CREATE_LIBRARY_AND_ARCHIVE_MODULES command appears to allow
you to save the footprints in the current board to either a new library
path chosen by the user or overwrite an existing pretty footprint
library.  I would think that this option alone would be sufficient but
maybe I'm not seeing why the command above needed.  The best description
I can think of for this is "Archive Footprints in Library".  You could
use this option to perform the same operation above.

It seems to med a better approach would be to just have a single archive
command and prompt the user for either a library table entry or library
path.  At least this would be easier to understand for the user.  I
didn't write this code so maybe I am missing something.

On 8/9/2017 6:24 AM, Fabrizio Tappero wrote:
> Hello,
> I am tinkering the appearance of some icons and I would like to improve
> the following menu by adding specific archive icons and make some of the
> text a little clearer. 
> 
> This is the current code:
> 
>     //----- archive submenu
> -----------------------------------------------------
>     wxMenu* submenuarchive = new wxMenu();
> 
>     AddMenuItem( submenuarchive, ID_MENU_ARCHIVE_MODULES_IN_LIBRARY,
>                  _( "&Archive Footprints in Project Library." ),
>                  _( "Archive footprints in existing library in footprint
> Lib table"
>                     "(does not remove other footprints in this library)" ),
>                  KiBitmap( library_update_xpm ) );
> 
>     AddMenuItem( submenuarchive, ID_MENU_CREATE_LIBRARY_AND_ARCHIVE_MODULES,
>                  _( "&Create Library and Archive Footprints." ),
>                  _( "Archive all footprints in new library\n"
>                     "(if the library already exists it will be deleted)" ),
>                  KiBitmap( library_xpm ) );
> 
>     AddMenuItem( aParentMenu, submenuarchive,
>                  ID_MENU_ARCHIVE_MODULES,
>                  _( "Arc&hive Footprints" ),
>                  _( "Archive or add footprints in library file" ),
>                  KiBitmap( library_xpm ) );
> 
> I would propose these changes:
> 
> _( "&Archive Footprints in Default Project Library" ),
> _( "Archive all footprints in existing default project library file"
>     "(does not remove other footprints in this library)" ),
>     "(the content of default library is maintained)" ),
> 
>  _( "&Create New Library and Archive Footprints" ),
> _( "Archive all footprints in new library file\n"
>     "(if library file already exists its content is rewritten)" ),
> 
>  _( "Arc&hive Footprints" ),
> _( "Archive or add footprints in library file" ), >> _( "Archive all
> footprints in library file" ),
> 
> For the option "Create New Library and Archive Footprints" I think it is
> not clear what library file will be used. Default Project Library sounds
> good to me but I dont think there is a default project library.
> 
> Any feedback is welcome
> cheers
> Fabrizio
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>