kicad-developers team mailing list archive

[Maciej Suminski <maciej.suminski@xxxxxxx>]

Hi Jon,

Thank you for the notice, I think you are right about making the values
consistent.

I changed the GRID_STYLE enum to match to match the grid options map as
it seemed more reasonable. I hope it will not be too disturbing for the
nightly users to adjust the grid settings, but it had to be fixed.

Regards,
Orson

On 08/31/2017 02:53 AM, Jon Evans wrote:
> Hi all,
> 
> I was looking into why my Gerbview GAL branch was defaulting to line grid
> when I thought it should be dots grid, and I found an inconsistency in the
> GAL display options code.
> 
> In gal_display_options.cpp, the grid options map (gridStyleConfigValues) go
> in this order: DOTS, LINES, SMALL_CROSS.  So dots == 0 and lines == 1.
> 
> In gal_display_options.h, enum GRID_STYLE has the order LINES, DOTS,
> SMALL_CROSS. So dots == 1 and lines == 0.
> 
> I think this should be fixed, maybe setting dots to be zero in the
> GRID_STYLE since that should be the default, but I don't feel too strongly
> about where to make the change.  The one issue is that this would
> potentially cause a settings change for people who already run the nightly
> builds, since the meaning of the setting could change.
> 
> -Jon
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>