← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] - Improve symbol library load speed

 

Oliver,

Nice catch!  I committed your patch to the master branch.  Thank you for
your contribution to KiCad.

Cheers,

Wayne

On 9/28/2017 6:06 AM, Oliver Walters wrote:
> Attached is a patch that provides a ~90% reduction in the time taken to
> load symbol libraries when launching eeschema.
> 
> Test case: Add all available libraries on my system to the search path.
> Prior to this patch, 40 seconds to load libraries. Now, 4 seconds!
> 
> Essentially, each pin was being tested against every other pin in the
> symbol, multiple times. Each test required a vector to be created and
> then destroyed.
> 
> Now these comparisons can be ignored, and (I think?) this makes sense at
> initial load.
> 
> Cheers,
> 
> Oliver
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References