kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] Collision-based select in library editor
Le 10/10/2017 à 20:46, Seth Hillbrand a écrit :
> Oh, that is much better. Thanks for the suggestion.
> Attached is the updated patch using EDA_RECT calls.
That was really fast!
I committed your patch.
> On Tue, Oct 10, 2017 at 11:16 AM, jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>
> Le 10/10/2017 à 18:41, Seth Hillbrand a écrit :
> > Thank you for testing, JP. I've corrected the issue. I had missed the inverted Y-axis in lib
> > editor. The attached patch functions correctly on all circles, in all quadrants.
> It works fine now.
> However, in order to simplify this code (and avoid duplicate code) could you consider using
> bool EDA_RECT::Intersects( const EDA_RECT& aRect ) const;
> to calculate if two rectangles intersect, both for text and circle.
> Again, thanks.
> Jean-Pierre CHARRAS