kicad-developers team mailing list archive

[Oliver Walters <oliver.henry.walters@xxxxxxxxx>]

JP,

Did you see my other response? I applied your patch and also fixed all the
outstanding issues that I was aware of.

I posted that response on 26th October.

Let me know if you want me to reattach the patch-set.

Cheers,

On Wed, Nov 1, 2017 at 9:11 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 18/10/2017 à 16:57, Oliver Walters a écrit :
> > JP,
> >
> > Fantastic, you have worked your magic! That works much better in pcbnew
> now, the undo/redo is
> > working well.
> >
> > However, I still see that undo/redo for zone editing is broken in
> modedit.
> >
> > Oliver
> >
> > On Wed, Oct 18, 2017 at 10:08 PM, jp charras <jp.charras@xxxxxxxxxx
> <mailto:jp.charras@xxxxxxxxxx>>
> > wrote:
> >
> >     Le 16/10/2017 à 15:08, Oliver Walters a écrit :
> >     > By 'segfault' I obviously meant assertion error. The Type() calls
> are returning:
> >     >
> >     > a) PCB_MODULE_T
> >     > b) PCB_ZONE_AREA_T
> >     >
> >     > Oliver
> >
> >     Hi Oliver,
> >
> >     Please, apply this patch to your working tree.
> >
> >     Currently, there is an issue when storing keepout area layers list
> in fp in files, when a board has
> >     only 2 layers:
> >     the option "internal layers" is lost, because there is no internal
> layer.
> >     Therefore the current way to store this option in file is not good.
> >
> >     --
> >     Jean-Pierre CHARRAS
>
> Hi Oliver,
>
> What is the status of your work on this feature?
> Are you still working on it to fix pending issues and finish it?
>
> Thanks.
>
>
> --
> Jean-Pierre CHARRAS
>