kicad-developers team mailing list archive

[Kristoffer Ödmark <kristofferodmark90@xxxxxxxxx>]

My 2 cents is that the headaches of storing values in mixed units, 
without indication of which unit they are stored as is a huge drawback 
for readability of the saved files and for maintainability.

Also I think the proposed new tag offset is a good idea, since the 
libraries can be gradually updated then. That the files cannot be opened 
by previous versions is a minor problem, since the files cannot be 
opened by kicad 4.07 anyway already.

On 11/09/2017 12:55 AM, Wayne Stambaugh wrote:
> This requires a file version bump and code that tests for prior versions
> before converting the units on read.  At that point, the file will no
> longer be compatible with prior version of KiCad.  I'm not opposed to
> this but I'm not sure it's worth the headaches it will cause.
>
> On 11/08/2017 03:33 PM, Oliver Walters wrote:
> > What about a controversial idea:
> >
> > Read "at" dimensions as inches, but new files write "offset" in mm.
> >
> > This preserves read compatibility but fixes the units issue going forward.
> >
> > On 9 Nov 2017 03:15, "jp charras" <jp.charras@xxxxxxxxxx
> > <mailto:jp.charras@xxxxxxxxxx>> wrote:
> >
> >      Le 08/11/2017 à 11:05, Oliver Walters a écrit :
> >      > Attached is a patch that fixes the problems I found in my 3D model
> >      array investigation. As
> >      > discussion on that is stalled for now, this patch simply fixes the
> >      model offset issues.
> >      >
> >      > 1. Display offset units in 3D preview window
> >      >
> >      > - Offset units are displayed (either inches or mm)
> >      >
> >      > 2. Fix offset in 3D rendering
> >      >
> >      > - It appears that the internal units for 3D model offset (mm) were
> >      being multiplied by 25.4 incorrectly
> >      > - Fixed rendering in OGL and Raytracing
> >      >
> >      > 3. Fix offset in 3D export
> >      >
> >      > - VRML export
> >      > - STEP export
> >      >
> >      > Oliver
> >
> >      Hi Oliver,
> >
> >      Looks like currently, Pcbnew stores 3D offset in inches, unlike any
> >      other value.
> >      This is very annoying, but we have to leave with that.
> >
> >      Therefore the patch breaks compatibility with any other Pcbnew
> >      version, if 3D offset is not 0.
> >
> >
> >      --
> >      Jean-Pierre CHARRAS
> >
> >      _______________________________________________
> >      Mailing list: https://launchpad.net/~kicad-developers
> >      <https://launchpad.net/~kicad-developers>
> >      Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >      <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >      Unsubscribe : https://launchpad.net/~kicad-developers
> >      <https://launchpad.net/~kicad-developers>
> >      More help   : https://help.launchpad.net/ListHelp
> >      <https://help.launchpad.net/ListHelp>
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

--
 -Kristoffer