← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix double "choose to" in symbol remap dialog.


Am 11.11.2017 um 11:07 schrieb jp charras:
>> while working on some translations I come over this commit or fixup and
>> noticed this and some other strings in the showed windows are not
>> translatable. I guess some _(...) magic is missing here? I have no full
>> knowledge about what needs to be changed here, thus I can't contribute a
>> patch.
> If you find some not translatable strings (missing _(...), or incorrectly built) just send us the
> filename and the line number to find these strings (if you are using Poedit, this is very easy).

Hmm, yes, I've should added that information.
The file in question is eeschema/dialogs/dialog_symbol_remap_base.cpp
the lines questionable are 24, 31, 34


The specific last commit (the origin of this thread) on this file was

It looks like those strings are some time longer not included to the
translatable strings.

> Note also strings displaying error messages for debug (showing a broken code) are not internationalized:
> - because they are usually not displayed in release mode.
> - and for maintainer, the original string is much better.

I know and these are valid reasons for this behavior. As the message is
visible in GUI I believe the current behavior isn't intentional.

Carsten Schoenert

Follow ups