kicad-developers team mailing list archive

[easyw <easyw@xxxxxxxxxxxx>]

Hi Wayne,
I don't think the offset was present i 3D rendering nor in the VRML 
exporter...
What I wanted to said in my previous mail was exactly that the patch 
provided was based on a wrong assumption...
Sorry if I was not clear...

3D viewer and exporter are just working fine... Oliver did the patch 
because noticed that the offset was in inches inside the footprint file 
and not in mm, but he didn't noticed that Mario already calculated 
correctly this value and displayed correctly in inches or millimetersin 
the viewer...

Attached here the 3D viewer result and the mail I posted to Oliver at 
the mailing list
> Hi Oliver,
>
> could you please explain me if the proposed patch/rework is fixing an issue in 3d visualization and/or exporting or just changing the fact that ATM the offset is stored in inches, compared to other values in mm?
>
> I remember that Mario avoided to change the internal kicad_pcb format, but fixed the displaying of the offset calculating it correctly and displaying correctly the value in inches or millimeters, depending on the pcb settings both in the editor or the model ...
>
> I never noticed a wrong offset in VRML when exporting a board and parts using the offset...
> Nor I noticed a wrong offset in 3D viewer ...
>
> I could say nothing about the step exporter because I use mine and so I never tested the internal step exporter...
>
> I attached an image of two cubes, the red is 1x1x1mm and the blue is 2x1x0.5mm.
> I applied an offset of 1x1x1 in mm to the second one, and the reciprocal positions are fine; moreover when I select the units to mm I get the offset displayed in mm, and if I set the unit in inches, the offset is displayed in inches...
>
> Maurice 



On 11/11/2017 9:15 PM, Wayne Stambaugh wrote:
> Oliver,
>
> I committed your patch to the KiCad development branch.
>
> Thanks,
>
> Wayne
>
> On 11/08/2017 05:05 AM, Oliver Walters wrote:
> > Attached is a patch that fixes the problems I found in my 3D model array
> > investigation. As discussion on that is stalled for now, this patch
> > simply fixes the model offset issues.
> >
> > 1. Display offset units in 3D preview window
> >
> > - Offset units are displayed (either inches or mm)
> >
> > 2. Fix offset in 3D rendering
> >
> > - It appears that the internal units for 3D model offset (mm) were being
> > multiplied by 25.4 incorrectly
> > - Fixed rendering in OGL and Raytracing
> >
> > 3. Fix offset in 3D export
> >
> > - VRML export
> > - STEP export
> >
> > Oliver
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: cubes-mm-in.jpg
Description: JPEG image