kicad-developers team mailing list archive

[Maciej Suminski <maciej.suminski@xxxxxxx>]

Hi Wayne,

I see the fragment code you mentioned, it is untouched. I will keep the
patches as a part of the library manager branch, so they get some extra
testing.

Cheers,
Orson

On 11/13/2017 12:05 AM, Wayne Stambaugh wrote:
> Hey Orson,
> 
> Keep in mind that the symbol does not know which library it is in.  That
> is determined when the library is parsed in SYMBOL_LIB_TABLE.  As long
> as you don't break that, I cannot think of a reason not to unify the
> symbol name but then again there are some quirks in the schematic code
> that still jump up an bite me from time to time.
> 
> Cheers,
> 
> Wayne
> 
> On 11/12/2017 06:00 PM, Maciej Suminski wrote:
>> Hi,
>>
>> I think this is a question to Wayne, but if others have any idea what
>> may go wrong, do not hesitate to reply.
>>
>> I have noticed that part name and library values are duplicated in a few
>> places in LIB_PART class and it is possible to set them individually. It
>> means there is a way to set each of them to a different value,
>> potentially causing more problems.
>>
>> With the attached patches, there is only one method to set all fields to
>> the same value. It is called in all places where the fields were
>> modified directly.
>>
>> My main concern is related to LIB_ID: are there any cases where the
>> LIB_ID name/library fields should be different than what is stored in
>> the LIB_PART fields?
>>
>> Regards,
>> Orson
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>