← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix for 3D model offset

 

Just a clarification request:

Kicad Stable has version assigned to 4
Previous stable had version assigned to 3

I imagine that next stable would have version assigned to 5...
Am I right in supposing the next numbering release?

If I'm fine, with the proposed patch the new stable release, if assigned coherently to actual releases numbering, will fail the check that is in this patch; the new parser will then mess up all 3D offsets each time the board will be saved/displayed...

+            if(m_requiredVersion < 20171114UL)

As I already stated the actual situation has no problem in displaying the correct offset in 3D viewer and the exporters are fine... The only 'issue', if we can say this is an issue, is that the offset is assigned to deci-mils and not millimeters inside the footprint...

This is going to open big headaches for which enhancement?
My 2 cents

Maurice



On 11/14/2017 10:55 AM, Oliver Walters wrote:
Wayne,

Please find attached updated patch set. If an old version is detected, inches are converted to mm.



Follow ups

References