← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Improve eeschema wire merging

 

Le 17/11/2017 à 13:42, Nick Østergaard a écrit :
> Isn't this the expected behavior? 
> 
> Usually you can sort of trim a wire by drawing from the end of it and into itself to remove that
> section.
> 

No: this is a merge algo, used to cleanup wires, and must merge collinear segments, not remove
connections.

the merging algo does not merge correctly these 2 collinear segments.
It *removes* an existing connection.

" draw a horizontal wire from point A to Point B.
Then draw a second wire from the middle of AB to B
the expected result is only one wire from A to B
but the result is one shorter wire from A to the middle of AB."

However if the second wire is created from the middle of AB to A, the merge is OK.



> 2017-11-17 11:03 GMT+01:00 jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>:
> 
>     Le 10/10/2017 à 07:19, Seth Hillbrand a écrit :
>     > Sorry for the repeat on this one.  I missed a corner case in testing the first time (overlapping,
>     > horizontal segments offset in Y)
>     >
>     > I've attached a collapsed patch for this.
>     >
>     > -Seth
>     >
> 
>     Hi Seth,
> 
>     I tested you patch and unfortunately it did not very well.
> 
>     For instance a basic case:
> 
>     draw a horizontal wire from point A to Point B.
> 
>     Then draw a second wire from the middle of AB to B.
>     the expected result is only on wire from A to B
>     but the result is one shorter wire from A to the middle of AB.
> 
> 
>     --
>     Jean-Pierre CHARRAS
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/%7Ekicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/%7Ekicad-developers>
>     More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> 


-- 
Jean-Pierre CHARRAS


References