kicad-developers team mailing list archive

[Seth Hillbrand <seth.hillbrand@xxxxxxxxx>]

Wayne-

I see what is happening here.  This is a separate issue but I'm happy to
submit a second patch.  Because you are dragging a full wire, Eeschema's
connectivity algorithm connects the ends of the bus with the ends of the
wire.  So dragging the full bus line grabbed all of the connected wires as
well.  You can see the effect of the currently proposed patch by performing
the same action with a wire/bus whose corners don't connect or a graphical
line on a wire or bus.

On the connection issue, I _think_ the correct behavior should be to only
connect buses to wires is via the wire-bus-entry link but before I submit a
patch with this, I'd like to check that this is the general view as well.

On the undo issue, this exists in master but is addressed by the junction
patch-set I sent earlier.

Best-
Seth

On Tue, Nov 28, 2017 at 4:39 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Hey Seth,
>
> I just tested this patch on Debian testing against f992d144d90 and I got
> the exact same behavior as I did on windows.  Is it possible this patch
> was created after some of your other wire/junction work.  I've attached
> a screen capture to show the behavior.  You can see the results of the
> drag undo as well.  HTH.
>
> Cheers,
>
> Wayne
>
> On 11/28/2017 04:44 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > Thanks for testing.  Oddly, I do not observe either of the effects you
> > describe on Mac or Linux (Debian), based off master (f992d144d).  Are
> > you running Windows?  If so, I'll try to find a VM to replicate this.
> >
> > Best-
> > Seth
> >
> > On Tue, Nov 28, 2017 at 12:43 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> >     Seth,
> >
> >     I just tested this.  The disambiguation menu is shown but it still
> drags
> >     both lines and it breaks the undo as well.  Maybe the undo part is
> fixed
> >     by your other patch set.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     On 11/27/2017 5:51 PM, Seth Hillbrand wrote:
> >     > ​In Eeschema, if you draw two lines on top of each other that are
> not
> >     > the same type, e.g. wire and bus; or bus and graphic line​, and
> then
> >     > hover over the lines and use the 'drag' hotkey, both lines will
> >     drag at
> >     > the same time.  The correct behavior should show disambiguation.
> >     >
> >     > The attached patch corrects this behavior by distinguishing the
> line
> >     > types in SCH_COLLECTOR::IsCorner().
> >     >
> >     > ​Reference: https://bugs.launchpad.net/kicad/+bug/1635984
> >     <https://bugs.launchpad.net/kicad/+bug/1635984>
> >     >
> >     > -Seth​
> >     >
> >     >
> >     >
> >     > _______________________________________________
> >     > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     > More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >     >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>