kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Hello

I just fell over some legacy stuff in the CMakeLists. It seems to not be
used, so therefore I propose to remove it.

This target seems to only create empty makefiles, tested on linux. And I
can not find any references to it in any of the current CMakeLists. Lets
remove it.

Nick

From ddf370f5968eaf99a08e28101664325332487531 Mon Sep 17 00:00:00 2001
From: Nick ?stergaard <oe.nick@xxxxxxxxx>
Date: Fri, 1 Dec 2017 20:21:20 +0100
Subject: [PATCH] Remove unused custom cmake target

This target seems to only create empty makefiles, tested on linux. And I
can not find any references to it in any of the current CMakeLists. Lets
remove it.
---
 CMakeLists.txt | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 565508c89..c70a34237 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -513,16 +513,6 @@ include( ${wxWidgets_USE_FILE} )
 #
 find_package( OpenGL REQUIRED )
 
-# Dick 5-Feb-2014:
-# Marco: We cannot use both ExternalProject_Add() add and find_package()
-# in the same CMake tree and have them both reference the same package:
-# http://stackoverflow.com/questions/6351609/cmake-linking-to-library-downloaded-from-externalproject-add
-# https://www.mail-archive.com/cmake@xxxxxxxxx/msg47501.html
-
-# Handle target used to specify if a target needs wx-widgets or other libraries
-# Always defined, empty if no libraries are to be built
-add_custom_target( lib-dependencies )
-
 #
 # Find GLEW library, required
 #
-- 
2.15.0