kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Every once in a while, someone submits a fix for a bug that I didn't
even remember existed, but that makes me want to hug them when it's
fixed.

On Wed, Dec 06, 2017 at 06:05:58PM +0000, Seth Hillbrand wrote:
> ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020
> 
> The current double-click handler in draw_panel​ gets overridden by the
> disambiguation menu, preventing double-clicks from being properly handled.
> This patch introduces a delay between the mouse up and handling the
> single-click.  If the double-click arrives in this time, the double-click
> is handled.  Otherwise, the normal single-click is processed.
> 
> Of note, we only introduce this delay in cases where the disambiguation
> menu is needed.  Otherwise, single-clicks are immediately processed.
> 
> Tested on MacOS and Linux.  The current delay is set to 250ms.  We might
> slow this down to 400-500ms but that felt a bit clunky to me.
> 
> -Seth