← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add double-click handling to disambiguation menu

 

I tested the patch on Linux and it works as advertised. Well done, we
need the same thing for GAL too.

Cheers,
Orson

On 12/06/2017 07:05 PM, Seth Hillbrand wrote:
> ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020
> 
> The current double-click handler in draw_panel​ gets overridden by the
> disambiguation menu, preventing double-clicks from being properly handled.
> This patch introduces a delay between the mouse up and handling the
> single-click.  If the double-click arrives in this time, the double-click
> is handled.  Otherwise, the normal single-click is processed.
> 
> Of note, we only introduce this delay in cases where the disambiguation
> menu is needed.  Otherwise, single-clicks are immediately processed.
> 
> Tested on MacOS and Linux.  The current delay is set to 250ms.  We might
> slow this down to 400-500ms but that felt a bit clunky to me.
> 
> -Seth
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References