← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Clean up unused junctions

 

Hi Wayne-

Nope.  It was part of the larger junction management patch set that was
already merged.

Best-
Seth

On Dec 10, 2017 3:33 PM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:

> Seth,
>
> Does this patch still needs to be applied?  I'm getting buried with the
> patch submissions.
>
> Thanks,
>
> Wayne
>
> On 09/27/2017 07:57 PM, Seth Hillbrand wrote:
> > Hi Jon-
> >
> > Thanks for catching that.  The delete node/delete connection follow a
> > different path to deletion, so I missed them initially.  As I was doing
> > this, I noticed a couple of corner cases where junctions were not
> > properly added/deleted, so this fixes that issue as well.
> >
> > There is one remaining issue, which is that junctions along the wire are
> > not deleted if they are no longer required.  But I'm holding off on
> > adding this because I don't think that we want to keep the wire crossing
> > multiple junctions and I'll try to lay out that proposal at a later date.
> >
> > Best-
> > Seth
> >
> > On Tue, Sep 26, 2017 at 5:58 PM, Jon Evans <jon@xxxxxxxxxxxxx
> > <mailto:jon@xxxxxxxxxxxxx>> wrote:
> >
> >     Hi Seth,
> >
> >     Neat feature!  I just checked this out and it does seem to work in
> >     most cases.
> >     There seem to be some situations where it doesn't remove junctions
> >     in my existing schematics -- when I use "delete connection" it
> >     works, but when I use "delete wire" it only works some of the time.
> >     I haven't looked closely at the code to see why this might be
> happening.
> >
> >     -Jon
> >
> >     On Tue, Sep 26, 2017 at 7:39 PM, Seth Hillbrand
> >     <seth.hillbrand@xxxxxxxxx <mailto:seth.hillbrand@xxxxxxxxx>> wrote:
> >
> >         ​Hi All-
> >
> >         Currently, when laying wire in eeschema, junctions are
> >         automatically added​ where needed.  This patch provides the
> >         reverse.  When deleting segments in eeschema, it automatically
> >         removes the junction if it is no longer needed.
> >
> >         This should save extra clicks when re-wiring and hopefully help
> >         new Kicad users keep their schematics cleaner.
> >
> >         Best-
> >         Seth
> >
> >         _______________________________________________
> >         Mailing list: https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/~kicad-developers>
> >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >         Unsubscribe : https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/~kicad-developers>
> >         More help   : https://help.launchpad.net/ListHelp
> >         <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References