kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32903
Re: Via dialog to support
Attached patch that implements the via choices, they seem to render fine
and work as expected under linux.
I guess that not many tests with different vias, since they have been
hard to use, and usually only used for larger projects. So please test
this a bit.
I found 1 bug/feature missing when doing this, the DRC doesnt warn if
there are vias that are buried are on the board, but not allowed in the
design rules.
I will file a bug report.
On 2018-01-06 21:51, Wayne Stambaugh wrote:
On 01/06/2018 02:46 PM, Tomasz Wlostowski wrote:
On 06/01/18 20:41, kristoffer Ödmark wrote:
The menu for the vias have the via type choice disabled, I cannot change
the via type from through via to buried via. It is grey.
Sorry, it's not implemented yet... Help appreciated.
This is going to have to fixed before stable v5. We cannot release with
a partially implemented feature.
Tom
- Kristoffer
On 2018-01-06 20:26, Wayne Stambaugh wrote:
What do you mean by can't get it to work. Is the via type not changing
or is it something else. Are you setting the layers correctly for a
buried/blind via?
On 01/06/2018 01:03 PM, kristoffer Ödmark wrote:
Hello!
I just tested changin a via to a buried/blind via but I cannot get it to
work, Is this a bug or am I missing something?. I have enabled the
blind/buried via in the design rules.
- Kristoffer
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
>From a4cc28ad33a664e7e7cd5ae5f4e74c03917be8a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kristoffer=20=C3=96dmark?= <kristoffer.odmark90@xxxxxxxxx>
Date: Sat, 6 Jan 2018 23:32:22 +0100
Subject: [PATCH] Implemented missing via dialog functions
---
pcbnew/class_track.cpp | 46 ++++++++--
pcbnew/class_track.h | 13 +++
pcbnew/dialogs/dialog_track_via_properties.cpp | 117 +++++++++++++++++++++++++
3 files changed, 168 insertions(+), 8 deletions(-)
diff --git a/pcbnew/class_track.cpp b/pcbnew/class_track.cpp
index 2ae4cebd7..0d9cd254c 100644
--- a/pcbnew/class_track.cpp
+++ b/pcbnew/class_track.cpp
@@ -428,17 +428,22 @@ LSET VIA::GetLayerSet() const
void VIA::SetLayerPair( PCB_LAYER_ID aTopLayer, PCB_LAYER_ID aBottomLayer )
{
- if( GetViaType() == VIA_THROUGH )
- {
- aTopLayer = F_Cu;
- aBottomLayer = B_Cu;
- }
-
- if( aBottomLayer < aTopLayer )
- std::swap( aBottomLayer, aTopLayer );
m_Layer = aTopLayer;
m_BottomLayer = aBottomLayer;
+ SanitizeLayers();
+}
+
+
+void VIA::SetTopLayer( PCB_LAYER_ID aLayer )
+{
+ m_Layer = aLayer;
+}
+
+
+void VIA::SetBottomLayer( PCB_LAYER_ID aLayer )
+{
+ m_BottomLayer = aLayer;
}
@@ -464,6 +469,31 @@ void VIA::LayerPair( PCB_LAYER_ID* top_layer, PCB_LAYER_ID* bottom_layer ) const
}
+PCB_LAYER_ID VIA::TopLayer() const
+{
+ return m_Layer;
+}
+
+
+PCB_LAYER_ID VIA::BottomLayer() const
+{
+ return m_BottomLayer;
+}
+
+
+void VIA::SanitizeLayers()
+{
+ if( GetViaType() == VIA_THROUGH )
+ {
+ m_Layer = F_Cu;
+ m_BottomLayer = B_Cu;
+ }
+
+ if( m_BottomLayer < m_Layer )
+ std::swap( m_BottomLayer, m_Layer );
+}
+
+
TRACK* TRACK::GetBestInsertPoint( BOARD* aPcb )
{
TRACK* track;
diff --git a/pcbnew/class_track.h b/pcbnew/class_track.h
index 67980d61f..e38ed6412 100644
--- a/pcbnew/class_track.h
+++ b/pcbnew/class_track.h
@@ -403,6 +403,9 @@ public:
*/
void SetLayerPair( PCB_LAYER_ID aTopLayer, PCB_LAYER_ID aBottomLayer );
+ void SetBottomLayer( PCB_LAYER_ID aLayer );
+ void SetTopLayer( PCB_LAYER_ID aLayer );
+
/**
* Function LayerPair
* Return the 2 layers used by the via (the via actually uses
@@ -412,6 +415,16 @@ public:
*/
void LayerPair( PCB_LAYER_ID* top_layer, PCB_LAYER_ID* bottom_layer ) const;
+ PCB_LAYER_ID TopLayer() const;
+ PCB_LAYER_ID BottomLayer() const;
+
+ /**
+ * Function SanitizeLayers
+ * Check so that the layers are correct dependin on the type of via, and
+ * so that the top actually is on top.
+ */
+ void SanitizeLayers();
+
const wxPoint GetPosition() const override { return m_Start; }
void SetPosition( const wxPoint& aPoint ) override { m_Start = aPoint; m_End = aPoint; }
diff --git a/pcbnew/dialogs/dialog_track_via_properties.cpp b/pcbnew/dialogs/dialog_track_via_properties.cpp
index 84e59f4a1..7b71dd03e 100644
--- a/pcbnew/dialogs/dialog_track_via_properties.cpp
+++ b/pcbnew/dialogs/dialog_track_via_properties.cpp
@@ -59,6 +59,10 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
OPT<int> viaDiameter = NULLOPT;
OPT<int> viaDrill = NULLOPT;
+ VIATYPE_T viaType = VIA_NOT_DEFINED;
+ PCB_LAYER_ID viaStartLayer = UNDEFINED_LAYER;
+ PCB_LAYER_ID viaEndLayer = UNDEFINED_LAYER;
+
m_haveUniqueNet = true;
int prevNet = -1;
@@ -91,6 +95,7 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
m_NetComboBox->SetMultiple( true );
}
+
// Look for values that are common for every item that is selected
for( auto& item : m_items )
{
@@ -150,6 +155,9 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
viaDiameter = v->GetWidth();
viaDrill = v->GetDrillValue();
m_vias = true;
+ viaType = v->GetViaType();
+ viaStartLayer = v->TopLayer();
+ viaEndLayer = v->BottomLayer();
}
else // check if values are the same for every selected via
{
@@ -164,6 +172,15 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
if( viaDrill && ( *viaDrill != v->GetDrillValue() ) )
viaDrill = NULLOPT;
+
+ if( viaType != v->GetViaType() )
+ viaType = VIA_NOT_DEFINED;
+
+ if( viaStartLayer != v->TopLayer() )
+ viaStartLayer = UNDEFINED_LAYER;
+
+ if( viaEndLayer != v->BottomLayer() )
+ viaEndLayer = UNDEFINED_LAYER;
}
if( v->IsLocked() )
@@ -175,8 +192,10 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
}
default:
+ {
wxASSERT( false );
break;
+ }
}
}
@@ -188,6 +207,7 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
setCommonVal( viaY, m_ViaYCtrl, m_viaY );
setCommonVal( viaDiameter, m_ViaDiameterCtrl, m_viaDiameter );
setCommonVal( viaDrill, m_ViaDrillCtrl, m_viaDrill );
+
m_DesignRuleViasUnit->SetLabel( GetAbbreviatedUnitsLabel( g_UserUnit ) );
int viaSelection = wxNOT_FOUND;
@@ -211,8 +231,44 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
m_DesignRuleViasCtrl->Connect( wxEVT_CHOICE, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaSelect ), NULL, this );
m_ViaDiameterCtrl->Connect( wxEVT_TEXT, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaEdit ), NULL, this );
m_ViaDrillCtrl->Connect( wxEVT_TEXT, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaEdit ), NULL, this );
+ m_ViaTypeChoice->Connect( wxEVT_CHOICE, wxCommandEventHandler( DIALOG_TRACK_VIA_PROPERTIES::onViaEdit ), NULL, this );
m_ViaDiameterCtrl->SetFocus();
+
+ m_ViaTypeChoice->Enable();
+
+ if( viaType == VIA_THROUGH )
+ m_ViaTypeChoice->SetSelection( 0 );
+ else if( viaType == VIA_MICROVIA )
+ m_ViaTypeChoice->SetSelection( 1 );
+ else if ( viaType == VIA_BLIND_BURIED )
+ m_ViaTypeChoice->SetSelection( 2 );
+ else if( viaType == VIA_NOT_DEFINED )
+ m_ViaTypeChoice->SetSelection( 3 );
+
+
+ m_ViaStartLayer->SetLayersHotkeys( false );
+ m_ViaStartLayer->SetLayerSet( LSET::AllNonCuMask() );
+ m_ViaStartLayer->SetBoardFrame( aParent );
+ m_ViaStartLayer->Resync();
+ m_ViaEndLayer->SetLayersHotkeys( false );
+ m_ViaEndLayer->SetLayerSet( LSET::AllNonCuMask() );
+ m_ViaEndLayer->SetBoardFrame( aParent );
+ m_ViaEndLayer->Resync();
+
+
+ m_ViaStartLayer->SetLayerSelection( viaStartLayer );
+ m_ViaEndLayer->SetLayerSelection( viaEndLayer );
+
+ m_ViaStartLayer->Enable( false );
+ m_ViaEndLayer->Enable( false );
+
+ if( viaType != VIA_THROUGH ) // check if selected type isnt through.
+ {
+ m_ViaStartLayer->Enable();
+ m_ViaEndLayer->Enable();
+ }
+
}
else
{
@@ -262,6 +318,7 @@ DIALOG_TRACK_VIA_PROPERTIES::DIALOG_TRACK_VIA_PROPERTIES( PCB_BASE_FRAME* aParen
m_lockedCbox->Set3StateValue( wxCHK_UNCHECKED );
}
+
m_StdButtonsOK->SetDefault();
// Pressing ENTER when any of the text input fields is active applies changes
@@ -361,6 +418,37 @@ bool DIALOG_TRACK_VIA_PROPERTIES::Apply( COMMIT& aCommit )
v->SetPosition( pos );
}
+ if( m_ViaTypeChoice->GetSelection() != 3)
+ {
+ switch( m_ViaTypeChoice->GetSelection() )
+ {
+ case 0:
+ v->SetViaType( VIA_THROUGH );
+ v->SanitizeLayers();
+ break;
+ case 1:
+ v->SetViaType( VIA_MICROVIA );
+ break;
+ case 2:
+ v->SetViaType( VIA_BLIND_BURIED );
+ break;
+ default:
+ break;
+ }
+
+ }
+
+ auto startLayer = static_cast<PCB_LAYER_ID>( m_ViaStartLayer->GetLayerSelection() );
+ auto endLayer = static_cast<PCB_LAYER_ID>( m_ViaEndLayer->GetLayerSelection() );
+
+ if (startLayer != UNDEFINED_LAYER )
+ v->SetTopLayer( startLayer );
+
+ if (endLayer != UNDEFINED_LAYER )
+ v->SetBottomLayer( endLayer );
+
+ v->SanitizeLayers();
+
if( m_viaNetclass->IsChecked() )
{
switch( v->GetViaType() )
@@ -378,6 +466,7 @@ bool DIALOG_TRACK_VIA_PROPERTIES::Apply( COMMIT& aCommit )
case VIA_MICROVIA:
v->SetWidth( v->GetNetClass()->GetuViaDiameter() );
v->SetDrill( v->GetNetClass()->GetuViaDrill() );
+
break;
}
}
@@ -475,6 +564,24 @@ void DIALOG_TRACK_VIA_PROPERTIES::onViaSelect( wxCommandEvent& aEvent )
void DIALOG_TRACK_VIA_PROPERTIES::onViaEdit( wxCommandEvent& aEvent )
{
m_DesignRuleViasCtrl->SetSelection( wxNOT_FOUND );
+
+ if( m_vias )
+ {
+ if( m_ViaTypeChoice->GetSelection() != 0 ) // check if selected type isnt through.
+ {
+ m_ViaStartLayer->Enable();
+ m_ViaEndLayer->Enable();
+ }
+ else
+ {
+ m_ViaStartLayer->SetLayerSelection( F_Cu );
+ m_ViaEndLayer->SetLayerSelection( B_Cu );
+
+ m_ViaStartLayer->Enable( false );
+ m_ViaEndLayer->Enable( false );
+ }
+ }
+
}
@@ -512,6 +619,16 @@ bool DIALOG_TRACK_VIA_PROPERTIES::check() const
m_ViaDrillCtrl->SetFocus();
return false;
}
+
+ }
+
+ if( m_vias)
+ {
+ if( m_ViaStartLayer->GetLayerSelection() == m_ViaEndLayer->GetLayerSelection() )
+ {
+ DisplayError( GetParent(), _( "Via start layer and end layer cannot be the same" ) );
+ return false;
+ }
}
return true;
--
2.15.1
Follow ups
References
