← Back to team overview

kicad-developers team mailing list archive

Re: Reproducible on Windows or Linux?

 

Correcting the dialog parent didn’t help, so I’m going to let that sleeping dog lie for 5.0.

The bug is in Cocoa.  wxWidgets calls:

SetWindowStyle( parentFlags & ~(wxTAB_TRAVERSAL) )

to send tabs to the layer popup.  The window style also contains some flags which affect the window layer, so wxWidgets does the equivalent of:

window.setLayer( window.layer )

It looks like a no-op, but it has the side-effect of reordering the windows in that layer.

I’ve patched wxWidgets to check for a layer change before setting it.


> On 14 Jan 2018, at 01:01, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> macos may be more strict about dialog parenting than other systems.  I
> doubt setting to correct parent will cause any issues with linux or windows
> 
> On 01/13/2018 07:59 PM, Jeff Young wrote:
>> Thanks, Wayne.
>> 
>> The combination of wxWidgets and OSX is so brain-dead that even if I fix that it might not cure the bug.  In any case, I’ll investigate….
>> 
>> Cheers,
>> Jeff.
>> 
>>> On 14 Jan 2018, at 00:51, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> 
>>> On linux the Footprint Text Properties dialog stays on top of the
>>> Footprint Properties dialog.  That being said, the parent window of the
>>> Footprint Text Properties dialog should be the Footprint Properties
>>> dialog not the footprint editor main window.
>>> 
>>> On 01/13/2018 07:44 PM, Jeff Young wrote:
>>>> Could someone check to see if:
>>>> 
>>>> https://bugs.launchpad.net/kicad/+bug/1692352
>>>> 
>>>> reproduces on Windows or Linux?
>>>> 
>>>> I suspect it’s OSX-specific, but we actually instantiate the
>>>> DialogEditModuleText as a child of the PCB_BASE_FRAME rather than the
>>>> DIALOG_MODULE_BOARD_EDITOR, so it might be cross-platform.
>>>> 
>>>> Thanks,
>>>> Jeff.
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 


Follow ups

References