← Back to team overview

kicad-developers team mailing list archive

Re: Schematic symbol chooser clarification


Attached is a minimal patch that differs the dialog title.

- Kristoffer

On 2018-02-05 13:25, Marco Ciampa wrote:
On Mon, Feb 05, 2018 at 01:10:08PM +0100, kristoffer Ödmark wrote:

I just spent some time trying to "debug" a library non-issue with a EE
switching from Altium for a test. He had added the libraries correctly, and
they showed up. But everytime he tried adding a symbol to the schematic, no
symbols was there. We sent pictures back and forth, and indeed the libraries
added, but did not show up.

To make a long hassle short, turns out the shortcut "P" is used to place
symbols in Altium, but to place Power symbols in kicad.
This is not an issue, however, there is no indication at all that the symbol
chooser is actually filtered or limited when using the shortcut key.

I think there could be benefits of adding some kind of visualization to the
symbol chooser that the list is limited to only power symbols, maybe just
changing the window title to something like "Choose Power Symbol" or the
more general term of adding the filter to the window name. Let me know what
you think
Also when you place a power symbol, the dialog shows normal symbols in
the history list, and it also permits to insert these symbols even if
they are not power symbols... that to me seems incoherent...

>From 0c0fe309e3ee9cc2286847f330d9310eefacb810 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kristoffer=20=C3=96dmark?= <kristoffer.odmark90@xxxxxxxxx>
Date: Thu, 8 Feb 2018 10:58:22 +0100
Subject: [PATCH] Differ the dialog text for when choosing power-symbols and
 all symbols

 eeschema/getpart.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/eeschema/getpart.cpp b/eeschema/getpart.cpp
index 4f54bb588..46dc53b58 100644
--- a/eeschema/getpart.cpp
+++ b/eeschema/getpart.cpp
@@ -159,7 +159,11 @@ SCH_BASE_FRAME::COMPONENT_SELECTION SCH_BASE_FRAME::SelectComponentFromLibrary(
     if( aHighlight && aHighlight->IsValid() )
         adapter->SetPreselectNode( *aHighlight, /* aUnit */ 0 );
-    dialogTitle.Printf( _( "Choose Symbol (%d items loaded)" ), adapter->GetComponentsCount() );
+    if( adapter->GetFilter() == CMP_TREE_MODEL_ADAPTER::CMP_FILTER_POWER )
+        dialogTitle.Printf( _( "Choose Power Symbol (%d items loaded)" ), adapter->GetComponentsCount() );
+    else
+        dialogTitle.Printf( _( "Choose Symbol (%d items loaded)" ), adapter->GetComponentsCount() );
     DIALOG_CHOOSE_COMPONENT dlg( this, dialogTitle, adapter, aConvert, aAllowFields, aShowFootprints );
     if( dlg.ShowQuasiModal() == wxID_CANCEL )

Follow ups